Skip to content

Don't initialize the loggers to None#911

Merged
ktf merged 1 commit intomasterfrom
nonone
Mar 24, 2025
Merged

Don't initialize the loggers to None#911
ktf merged 1 commit intomasterfrom
nonone

Conversation

@singiamtel
Copy link
Copy Markdown
Collaborator

It confuses the typing check

As discussed beforehand, my goal is to eventually pass these strict mypy filter settings

I'll be tracking the progress in each PR, and try to fix the low hanging fruit first

-Found 788 errors in 33 files (checked 35 source files)
+Found 664 errors in 33 files (checked 35 source files)

The mypy filter

[mypy]
python_version = 3.12
platform = linux
plugins = pydantic.mypy
show_error_codes = true
follow_imports = normal
local_partial_types = true
strict_equality = true
no_implicit_optional = true
warn_incomplete_stub = true
warn_redundant_casts = true
warn_unused_configs = true
warn_unused_ignores = true
enable_error_code = ignore-without-code, redundant-self, truthy-iterable
disable_error_code = annotation-unchecked, import-not-found, import-untyped
extra_checks = false
check_untyped_defs = true
disallow_incomplete_defs = true
disallow_subclassing_any = true
disallow_untyped_calls = true
disallow_untyped_decorators = true
disallow_untyped_defs = true
warn_return_any = true
warn_unreachable = true

[pydantic-mypy]
init_forbid_extra = true
init_typed = true
warn_required_dynamic_aliases = true
warn_untyped_fields = true

It confuses the typing check
@ktf ktf merged commit 12f8014 into master Mar 24, 2025
11 checks passed
@ktf ktf deleted the nonone branch March 24, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants